Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Merge the add-description changes #35

Merged
merged 9 commits into from
Oct 30, 2023
Merged

[ENH] Merge the add-description changes #35

merged 9 commits into from
Oct 30, 2023

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Oct 30, 2023 •
edited by alyssadai
Loading

Closes #

Changes proposed in this pull request:

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs requested a review from alyssadai October 30, 2023 18:11
alyssadai
alyssadai approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @surchs!

Just two questions from me, otherwise 🧑‍🍳

run_bagel_cli.sh Show resolved Hide resolved
silly.json Outdated Show resolved Hide resolved
@alyssadai alyssadai merged commit a6dfa82 into main Oct 30, 2023
2 checks passed
@alyssadai alyssadai deleted the add-description branch October 30, 2023 19:27
@alyssadai alyssadai mentioned this pull request Oct 31, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssadai alyssadai alyssadai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surchs @alyssadai