-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Allow stratifying phenotypic column histogram by session #106
Conversation
- change to grouped bars per bin - reduce gap between plot and legend / axis titles
Hey @nikhil153, looping you in here in case you have any functional feedback on the new feature (no worries if not). 🙂 |
Thanks @alyssadai ! |
Hey @nikhil153, I've pushed a change that displays, on hover, the participant ID of outlier points in the box plot along with the column value. I've also jittered the points so outliers can be differentiated more easily. Let me know if that's what you were looking for 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool PR @alyssadai 🎉
I tested it out locally, seems to do all the things you say! Seeing how much of a pain these selenium tests are for UI testing, I won't suggest you add any, maybe we can take some time after OHBM and see if there is an easier way.
Good to go 🧑🍳
@alyssadai - That's perfect! Thanks :) |
Closes #95
Changes proposed in this pull request:
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: