Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add Dockerfile and workflow to push to DockerHub #150

Merged
merged 5 commits into from
May 31, 2024
Merged

[CI] Add Dockerfile and workflow to push to DockerHub #150

merged 5 commits into from
May 31, 2024

Conversation

alyssadai
Copy link
Collaborator

@alyssadai alyssadai commented May 29, 2024 •
edited by surchs
Loading

Changes proposed in this pull request:

  • Also updated README with instructions on running digest in Docker container
  • Fixed sneaky typo detected by codespell

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai changed the title Add Dockerfile and workflow to push to DockerHub [CI] Add Dockerfile and workflow to push to DockerHub May 29, 2024
@alyssadai alyssadai requested a review from surchs May 29, 2024 01:03
surchs
surchs approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

🧑‍🍳

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
README.md Show resolved Hide resolved
@alyssadai alyssadai mentioned this pull request May 31, 2024
Open
@alyssadai alyssadai merged commit c5f62bd into main May 31, 2024
4 checks passed
@alyssadai alyssadai deleted the create-dockerfile branch May 31, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Dockerfile
2 participants
@alyssadai @surchs