Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Make basic check of input filetype more robust to poor file naming #92

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

alyssadai
Copy link
Collaborator

@alyssadai alyssadai commented Oct 6, 2023

Closes #90

Changes proposed in this pull request:

  • Check for apparent CSV filetype now looks at the suffix instead of anywhere in the filename for ".csv"

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🧑‍🍳

is it worth to add a (silly) test case that would not have passed before?

@alyssadai
Copy link
Collaborator Author

@surchs added a test for the file suffix check! (fc5e0ff)

want to have a quick look and, if it makes sense, check off the box in the checklist? 😄

@alyssadai alyssadai merged commit 02ca7a0 into main Oct 6, 2023
2 checks passed
@alyssadai alyssadai deleted the improve-filetype-check branch October 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the uploaded file type checker smarter to only look at suffixes
2 participants