Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

[FIX] Implemented logic to handle cases where no diagnosis/assessment exist in the graph #350

Merged
merged 6 commits into from
Jan 7, 2024

Conversation

rmanaem
Copy link
Collaborator

@rmanaem rmanaem commented Jan 4, 2024

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for neurobagel-query-tool ready!

Name Link
🔨 Latest commit 66464d7
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query-tool/deploys/659b31cc24f6f50008d00432
😎 Deploy Preview https://deploy-preview-350--neurobagel-query-tool.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review January 5, 2024 16:56
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @rmanaem, tests look good, other stuff makes sense. I left some 🍒 comments for you to look at, but good to go 🧑‍🍳

One thing to check before merging: in the staging build I cannot see any toast appear, even though the assessment and diagnosis are both empty. We should make sure this is expected - and then fix this.

components/QueryForm.vue Show resolved Hide resolved
cypress/e2e/APIRequest.cy.js Outdated Show resolved Hide resolved
cypress/e2e/APIRequest.cy.js Outdated Show resolved Hide resolved
@rmanaem rmanaem merged commit 2323de5 into main Jan 7, 2024
8 checks passed
@rmanaem rmanaem deleted the bug-328 branch January 7, 2024 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle case where no diagnosis/assessment exist in the graph
2 participants