-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand info on matching dataset cards Fixes #377 #421
Open
ShubhamShekhawat
wants to merge
1
commit into
neurobagel:main
Choose a base branch
from
ShubhamShekhawat:expand-info-dataset-cards
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Expand info on matching dataset cards Fixes #377 #421
ShubhamShekhawat
wants to merge
1
commit into
neurobagel:main
from
ShubhamShekhawat:expand-info-dataset-cards
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd aggregate dataset indicators
Reviewer's Guide by SourceryThis pull request enhances the ResultCard component to display whether a dataset is a DataLad dataset or an aggregate dataset. This addresses issue #377. Class diagram showing updated ResultCard component propsclassDiagram
class ResultCard {
+String nodeName
+String datasetName
+String datasetUUID
+String datasetDescription
+Number datasetTotalSubjects
+Number numMatchingSubjects
+String[] imageModals
+Object pipelines
+Boolean checked
+Function onCheckboxChange
+Boolean isDataLad
+Boolean isAggregate
}
note for ResultCard "Added isDataLad and isAggregate props"
class ResultContainer {
-String[] download
-Boolean selectAll
+updateDownload()
+render()
}
ResultContainer --> ResultCard : passes props
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
github-actions
bot
added
the
_community
[BOT ONLY] PR label for community contributions. Used for tracking
label
Dec 27, 2024
❌ Deploy Preview for neurobagel-query failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isDataLad
andisAggregate
indicators toResultCard
component.ResultContainer
toResultCard
.Fixes Expand info on matching dataset cards #377
@alyssadai Mam please check and if something is wrong let me know.
Summary by Sourcery
New Features: