Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand info on matching dataset cards Fixes #377 #421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShubhamShekhawat
Copy link

@ShubhamShekhawat ShubhamShekhawat commented Dec 27, 2024

  • Added isDataLad and isAggregate indicators to ResultCard component.
  • Passed required props from ResultContainer to ResultCard.
  • Displayed labels for whether the dataset is a DataLad dataset or aggregate.
  • Verified functionality against test cases.
    Fixes Expand info on matching dataset cards #377
    @alyssadai Mam please check and if something is wrong let me know.

Summary by Sourcery

New Features:

  • Added indicators for whether a dataset is a DataLad dataset or an aggregate dataset.

Copy link

sourcery-ai bot commented Dec 27, 2024

Reviewer's Guide by Sourcery

This pull request enhances the ResultCard component to display whether a dataset is a DataLad dataset or an aggregate dataset. This addresses issue #377.

Class diagram showing updated ResultCard component props

classDiagram
    class ResultCard {
        +String nodeName
        +String datasetName
        +String datasetUUID
        +String datasetDescription
        +Number datasetTotalSubjects
        +Number numMatchingSubjects
        +String[] imageModals
        +Object pipelines
        +Boolean checked
        +Function onCheckboxChange
        +Boolean isDataLad
        +Boolean isAggregate
    }
    note for ResultCard "Added isDataLad and isAggregate props"

    class ResultContainer {
        -String[] download
        -Boolean selectAll
        +updateDownload()
        +render()
    }
    ResultContainer --> ResultCard : passes props
Loading

File-Level Changes

Change Details Files
Added isDataLad and isAggregate indicators to display DataLad and aggregate dataset information.
  • Passed isDataLad and isAggregate props from ResultContainer to ResultCard.
  • Added conditional rendering of "DataLad dataset" and "Aggregate dataset" labels in ResultCard based on the respective prop values.
  • Included tooltips for available pipelines in ResultCard.
  • Verified the functionality against test cases to ensure correct behavior and data handling.
src/components/ResultCard.tsx
src/components/ResultContainer.tsx
Updated Result Container to pass DataLad and aggregate information
  • Passed item.is_data_lad to the isDataLad prop of ResultCard.
  • Passed item.is_aggregate to the isAggregate prop of ResultCard.
src/components/ResultContainer.tsx

Assessment against linked issues

Issue Objective Addressed Explanation
#377 Add indicator showing if dataset is a DataLad dataset
#377 Add indicator showing if dataset is an aggregate dataset

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the _community [BOT ONLY] PR label for community contributions. Used for tracking label Dec 27, 2024
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for neurobagel-query failed.

Name Link
🔨 Latest commit 39b8907
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/676e4de7415fe6000823d2cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_community [BOT ONLY] PR label for community contributions. Used for tracking
Projects
Status: Community
Development

Successfully merging this pull request may close these issues.

Expand info on matching dataset cards
1 participant