Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Updated README.md #89

Merged
merged 6 commits into from
Mar 20, 2024
Merged

[DOC] Updated README.md #89

merged 6 commits into from
Mar 20, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Mar 18, 2024

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-documentation Change that only affects user documentation label Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 8868546
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65fb20a0b8460b0008850987
😎 Deploy Preview https://deploy-preview-89--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review March 18, 2024 23:31
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rmanaem, thanks a lot for taking this on, very nice detailed README (sorry for the late review, I thought I had already submitted)!

I left a bunch of comments and suggestions, but all are optional so I'm approving already. Take a look and see what you agree with, then 🧑‍🍳

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@rmanaem rmanaem merged commit 4379af8 into main Mar 20, 2024
9 checks passed
@rmanaem rmanaem deleted the doc-85 branch March 20, 2024 21:44
@surchs
Copy link
Contributor

surchs commented Apr 11, 2024

🚀 PR was released in v0.2.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-documentation Change that only affects user documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README.md
2 participants