⚡ Make sure Neutralino binaries have the right permissions #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed syntax-wise but it drove syntax highlighting in VSCode mad, as {} are usually used for quantifiers in regEx.
|
Fun fact: I've just replicated the issue with missing +x flags on Fedora 41. |
shalithasuranga
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Thanks so much for sending this fix @CosmoMyzrailGorynych 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Mac user of ct.js reported that
npx @neutralinojs/neu create neuTestAppdownloaded binaries without the+xflags, which lead toEPERMerrors orExecutable not found in $PATHwhen run through other tools. Though I myself could not replicate it in a Mac VM, I suppose it is due to some security measure in newer macOS versions.This PR adds a simple fs.chmodSync call on every non-windows binary when run on system other than Windows to make sure the executables have the right execution flags.
It also makes a function-less change to regEx statements in the code so VSCode's syntax highlighter doesn't break. (
<pattern>{N,M}are used for quantifiers and ir seems that VSCode tokenizer detects any{}pair as one.)