Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Stocks to Photography Collections #86

Merged
merged 2 commits into from
Jan 28, 2016

Conversation

plainspace
Copy link
Contributor

This PR adds The Stocks to the Photography sections and adds a sub-section called Photography Collections.

@neutraltone
Copy link
Owner

Nice add, one thing, i've actually been adding aggregated content sites to the aggregated content section as these websites might not always be exclusive to photos.

I'm torn as to which is a better approach.

@plainspace
Copy link
Contributor Author

@neutraltone your call! just lmk... I'd love to contrib.

@neutraltone
Copy link
Owner

Cool, would you be able to instead add "The Stocks" to the existing aggregated section and I will raise and issue to assess how things are at some point. That way if the aggregated section gets any longer I can think about moving it to your proposed method.

Thanks!

@plainspace
Copy link
Contributor Author

Sounds good. Lmk what you think.

neutraltone added a commit that referenced this pull request Jan 28, 2016
Add The Stocks to Photography Collections
@neutraltone neutraltone merged commit b7209e9 into neutraltone:master Jan 28, 2016
@neutraltone
Copy link
Owner

Good stuff, cheers!

I'll have a think about issue #88 and probably tackle a load of them over the weekend.

@plainspace plainspace deleted the photography-thestocks branch January 29, 2016 17:41
@CodeBrauer CodeBrauer mentioned this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants