Skip to content

Commit

Permalink
Merge pull request #173 from neutrinoceros/depr_cycle
Browse files Browse the repository at this point in the history
DEPR: remove deprecated yt_idefix.loaders module
  • Loading branch information
neutrinoceros authored Jan 28, 2023
2 parents f7fca4c + 7508e31 commit c5cae43
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 129 deletions.
11 changes: 0 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,3 @@ python -m pip install git+https://github.com/yt-project/yt.git
- `yt>=4.1.0` is required from `yt.ProjectionPlot`

Streched grids support is considered experimental as of yt 4.1


## Deprecated features
*will be removed in yt_idefix 1.0*

yt_idefix ships a specialized loader function for datasets with streched grids
`yt_idefix.load_stretched`. This function is only provided as a workaround 4.0.x limitations, but it's highly limited itself:
- no field magic (no aliasing, or dimensionalization, or automatic derived field generation)
- no lazy loading (all data has to reside in memory)
- projections are not supported
- only supports vtk outputs (not dumps)
12 changes: 0 additions & 12 deletions tests/test_vtk.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
from unyt import Unit, assert_allclose_units

import yt
import yt_idefix
from yt_idefix.api import IdefixVtkDataset, PlutoVtkDataset
from yt_idefix.loaders import VisibleDeprecationWarning

# A sample list of units for test.
# The first three values are chosen randomly
Expand Down Expand Up @@ -226,13 +224,3 @@ def test_projection_plot(vtk_file):
def test_load_magic(vtk_file):
ds = yt.load(vtk_file["path"], geometry=vtk_file["geometry"])
assert isinstance(ds, IdefixVtkDataset)


def test_load_stretched(vtk_file):
with pytest.raises(
VisibleDeprecationWarning,
match=r"yt_idefix.load_strecthed is deprecated "
r"and will be removed completely in a future version\. "
r"Please use yt.load instead\.",
):
yt_idefix.load_stretched(vtk_file["path"], geometry=vtk_file["geometry"])
1 change: 0 additions & 1 deletion yt_idefix/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@
IdefixVtkHierarchy,
PlutoVtkDataset,
)
from .loaders import load, load_stretched
105 changes: 0 additions & 105 deletions yt_idefix/loaders.py

This file was deleted.

0 comments on commit c5cae43

Please sign in to comment.