Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support set monitor info and scale #224

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

Nexarian
Copy link
Contributor

@Nexarian Nexarian commented Jul 9, 2022

This is a shameless copy of
#172 for my own prototyping
and editing purposes.

We need to figure out how to get xf86SetDpi working.

This is a shameless copy of
neutrinolabs#172 for my own prototyping
and editing purposes.

We need to figure out how to get xf86SetDpi working.
Copy link
Member

@matt335672 matt335672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all looks fine to me, when between us we've figured out what to do with the physical size from the core message.

monitor.physical_width
= clientCon->client_info.display_sizes.session_width;
monitor.physical_height
= clientCon->client_info.display_sizes.session_height;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see where your comment about putting the physical size into neutrinolabs/xrdp#2310 is coming from now.

As I said in response to your comment, that only makes sense in a single monitor scenario. Let me know what your thoughts are in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants