limit dirty region complexity, remove no monitor list banding #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I've tested on a bare 4K monitor as used by @metalefty in #318 and also on a 4K XFCE display running xeyes. I've taken the liberty of modifying your comment above for future tracing of what we did when. When you've merged this I'll cherry-pick back to the v0.10.x branch for neutrinolabs/xrdp#3155. |
|
Is #288 required to backport this to v0.10? |
|
It's not, but I think #288 should go into v0.10 anyway. |
|
My mistake - there are a few changes in #288 which are causing problems with backporting this. I'll put a PR together for both. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318