Allow for empty fields in TS_EXTENDED_INFO_PACKET #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some clients appears to be sending cbClientAddress and/or cbClientDir as 0 in the TS_EXTENDED_INFO_PACKET. This appears to be at odds with [MS-RDPBCGR] which requires mandatory terminators for these fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2853
Tested by @derekschrock
Some clients appears to be sending cbClientAddress and/or cbClientDir as 0 in the TS_EXTENDED_INFO_PACKET. This appears to be at odds with [MS-RDPBCGR] which requires mandatory terminators for these fields.
This PR addresses this by not parsing the fields we are not currently using. Additionally, a few ints have been made unsigned to simplify length checks for incoming data.