Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated docs about new gov gated params #211

Merged
merged 2 commits into from
Sep 2, 2024
Merged

feat: updated docs about new gov gated params #211

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7173ae8
upodated docs about new gov gated params
swelf19 Jul 26, 2024
8bb77cc
Update docs/neutron/modules/interchain-queries/messages.md
swelf19 Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/neutron/modules/interchain-queries/messages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ message KVKey {
}
```

> **Note:** the maximum allowed number of KVKey values for a single InterchainQuery equals to 32.
> **Note:** the maximum allowed number of KVKey values for a single InterchainQuery a module's param `MaxKvQueryKeysCount`, default value is 32.
swelf19 marked this conversation as resolved.
Show resolved Hide resolved

Currently `query_type` can take the following values:
* `kv` - query **values** from Cosmos-SDK KV-storage on remote chain which are stored under some **keys**. In this case `kv_keys` must be filled in.
Expand Down
4 changes: 2 additions & 2 deletions docs/neutron/modules/interchain-queries/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ You can see more info, examples and recommendations about proper transactions re
[{"field": "{eventType}.{attributeKey}", "val": "{attributeValue}", "op": "gte"}, ...]
```

Maximum allowed amount of filters is 32. Supplying more filters than allowed will return an error.
Maximum allowed amount of filters is defined by a module's param `MaxTransactionsFilters`, the default value is 32. Supplying more filters than allowed will return an error.

Supported operators:
* `eq`
Expand Down Expand Up @@ -155,7 +155,7 @@ By understanding the usage of the `transactions_filter` field, developers and us
2. **Incrementally Refine**: If needed, add additional filters incrementally to refine the results, testing at each stage to ensure relevance.
3. **Avoid Redundancy**: Ensure that each filter adds value to the query and that there are no redundant or conflicting filters.
4. **Test Performance**: Consider testing the query with different numbers of filters to gauge performance and result relevance, especially if using many filters.
5. **Use the Maximum Limit Wisely**: Note that the maximum allowed amount of 32 filters is a technical constraint.
5. **Use the Maximum Limit Wisely**: Note there is a maximum allowed amount of filters defined by a module's param `MaxTransactionsFilters`.

##### How Many Filters Do You Need?

Expand Down
Loading