Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sdk-47 params test NTRN-113 #223

Merged
merged 8 commits into from
Nov 8, 2023
Merged

add sdk-47 params test NTRN-113 #223

merged 8 commits into from
Nov 8, 2023

Conversation

quasisamurai
Copy link
Contributor

@quasisamurai
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/6533928970/job/17747811926

sotnikov-s
sotnikov-s requested changes Oct 24, 2023
View reviewed changes
src/helpers/proposal.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Outdated Show resolved Hide resolved
NeverHappened
NeverHappened requested changes Oct 30, 2023
View reviewed changes
src/helpers/proposal.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Outdated Show resolved Hide resolved
sotnikov-s
sotnikov-s requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the new comments, I still see a number of misprints/ambiguities/unaccounted comments from the previous time

src/helpers/cosmos.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Outdated Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Show resolved Hide resolved
src/testcases/run_in_band/parameters.test.ts Show resolved Hide resolved
@quasisamurai
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/6533928970

@pr0n00gler pr0n00gler merged commit 57142eb into feat/upd-47 Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotnikov-s sotnikov-s sotnikov-s approved these changes

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@NeverHappened NeverHappened NeverHappened approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quasisamurai @NeverHappened @pr0n00gler @sotnikov-s