Feat: software upgrade via chain manager [NTRN-400] #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts into feat/software-upgrade-via-chain-manager
sotnikov-s
changed the title
pr0n00gler
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task
https://hadronlabs.atlassian.net/browse/NTRN-400
this PR
MsgSoftwareUpgradeandMsgCancelSoftwareUpgradeadminmodule messages being sent via respestive introduced chain manager strategies;MsgAddScheduleandMsgRemoveScheduletests so they don't have SubDAO involved but an ordinary account. Decided to do that when handled accidentally failingadd scheduletest with a totally uninformative and untraceable errorexpected executed, got execution_failedonAddScheduleSubDAO proposal execution to 1) get rid of poor error; 2) speed the tests up (interaction with chain manager from an ordinary account is much faster than from the SubDAO). Viewing and understanding the cron-related diff will be much easier if you first check out the way the upgrade-related tests are written because the new cron-related tests are written the same way.related PRs: