feat: add possibility for unordered ica channels #ntrn-376 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverHappened
force-pushed
the
feat/unordered-ica
branch
from
fd2f5c4 to
f2faefb
Compare
NeverHappened
force-pushed
the
feat/unordered-ica
branch
from
f2faefb to
d3b24c5
Compare
swelf19
reviewed
Aug 30, 2024
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq, JsonSchema)] | ||
| #[serde(rename_all = "SCREAMING_SNAKE_CASE")] | ||
| pub enum ChannelOrdering { | ||
| None, |
There was a problem hiding this comment.
Seems like it should be ORDER_NONE_UNSPECIFIED and if you set Ordering to None variant you get the error https://github.com/neutron-org/neutron/blob/b3a0f5d2a31d37a8ac91e81308762f8fc39ea4f3/wasmbinding/message_plugin.go#L877 because there is no NONE in a values map.
joldie777
previously approved these changes
Sep 2, 2024
swelf19
previously approved these changes
Sep 2, 2024
pr0n00gler
dismissed stale reviews from swelf19 and joldie777
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hadronlabs.atlassian.net/browse/NTRN-376
Now ICA accounts can be with unordered channels.
They do not close after timeout. And messages be delivered in random order.
PR's: