v5.0.2 upgrade handler #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swelf19
reviewed
Nov 22, 2024
| }{ | ||
| { | ||
| name: "sending tokenfactory denom from module to module with infinite contract should panic", | ||
| wasmFile: "./testdata/infinite_track_beforesend.wasm", |
There was a problem hiding this comment.
Links to contracts source code would be helpful.
| }, | ||
| { | ||
| name: "Try using no 100", | ||
| wasmFile: "./testdata/no100.wasm", |
There was a problem hiding this comment.
Not sure i understand, what the contract does, could you give a brief description?
go.mod
Outdated
| @@ -218,6 +218,7 @@ require ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| cosmossdk.io/math => cosmossdk.io/math v1.4.0 | |||
There was a problem hiding this comment.
It's already 1.4.0, if you don't want to prevent future updates, i think it's not necessarily to set a replacement
There was a problem hiding this comment.
Doesn't this replace force for v1.4.0 to be used in all dependencies?
| } | ||
|
|
||
| // set beforesend hook to the new denom | ||
| // we register infinite loop contract here to test if we are gas metering properly |
There was a problem hiding this comment.
As far as i can see, no100 in the list of testcases and it's not infinite loop. Comment misleading?
| tokenToSend = tc.tokenToSend | ||
| } | ||
|
|
||
| // send the mint module tokenToSend |
zavgorodnii
previously approved these changes
Nov 23, 2024
Co-authored-by: swelf19 <62722506+swelf19@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v5.0.2 upgrade handler + tokenfactory tests + increasage of tf gas limit call
Related PR: