feat: added interchain security, ibcratelimit. updated dex #NTRN-408 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2024
joldie777
approved these changes
Nov 20, 2024
sotnikov-s
reviewed
Nov 25, 2024
Comment on lines
+70
to
+72
| ibcratelimit: { | ||
| v1beta1: new (await import("./ibcratelimit/v1beta1/tx.rpc.msg")).MsgClientImpl(rpc), | ||
| }, |
There was a problem hiding this comment.
why no ICS msg server here? and same about query server in rpc.query.ts?
There was a problem hiding this comment.
another related question: why do we have src/neutron/rpc.tx.ts and src/interchain_security/rpc.tx.ts? same about rpc.query.ts
There was a problem hiding this comment.
Good question, this is generated code, we need to fix/rewrite the generator if we want to collect all the modules under one msg server
sotnikov-s
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes auto-generated code for the
ibcratelimitmodule and for theinterchain securitymodules. Types and services.Task definition: Add updateParamsPersimmon to chain manager (https://github.com/neutron-org/neutron-dao/tree/main/contracts/dao/neutron-chain-manager) for the following modules:
All prs:
#10
neutron-org/neutronjsplus#69
neutron-org/neutron-integration-tests#368
neutron-org/neutron-dao#116
neutron-org/neutron-std#8
neutron-org/neutron#765