Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Authorization header for livedata #169

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Jul 8, 2024

After we deploy a version containing neutrons/live_data_server#21 we can change the method we use to pass the "key".

You can test this work by following the same testing as #167

Ref: 5923: [LiveDataServer] Change API key handling

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.01%. Comparing base (636c61e) to head (3e5b72f).

Files Patch % Lines
src/webmon_app/reporting/report/view_util.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #169      +/-   ##
==========================================
- Coverage   77.05%   77.01%   -0.04%     
==========================================
  Files          50       50              
  Lines        4615     4608       -7     
==========================================
- Hits         3556     3549       -7     
  Misses       1059     1059              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rosswhitfield rosswhitfield merged commit 157d1ba into next Jul 8, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the live_plot_Authorization branch July 8, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants