Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python django and postgresql #20

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Jul 3, 2024

Ref 5460: LiveDataServer: Upgrade Django, Python and PostgreSQL

This moves the version of python to 3.12, django to 4.2 and postgresql to 16. And from psycopg2 to psycopg 3. Only a few settings needed to be updated.

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (5f2c914) to head (0f978c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #20      +/-   ##
==========================================
+ Coverage   86.95%   87.14%   +0.18%     
==========================================
  Files          10       10              
  Lines         276      280       +4     
==========================================
+ Hits          240      244       +4     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosswhitfield rosswhitfield marked this pull request as ready for review July 3, 2024 03:04
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual test_client.py does create plots for json and html flavors in the local deploy of the app

@rosswhitfield rosswhitfield merged commit 0f54021 into next Jul 3, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the update_python_django_postgresql branch July 3, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants