-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update excluded processes for Azure Linux App Service #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Update Profiler NuGet Package Reference to v10.33.1.3. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
jaffinito
previously approved these changes
Nov 4, 2024
nrcventura
previously approved these changes
Nov 4, 2024
nr-ahemsath
previously approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
tippmar-nr
dismissed stale reviews from nr-ahemsath, nrcventura, and jaffinito
via
November 4, 2024 19:19
84826d2
tippmar-nr
changed the title
fix: Exclude
fix: Update excluded processes for Azure Linux App Service
Nov 4, 2024
kuduagent.dll
from instrumentationchore: Update Profiler NuGet Package Reference to v10.33.1.6. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
=======================================
Coverage 81.40% 81.41%
=======================================
Files 464 464
Lines 29524 29525 +1
Branches 3266 3266
=======================================
+ Hits 24035 24037 +2
+ Misses 4695 4692 -3
- Partials 794 796 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nrcventura
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: Don't instrument certain processes in Azure Linux App Service deployments. Resolves #2871.
END_COMMIT_OVERRIDE
Updates the Profiler to exclude
kuduagent.dll
andDiagServer
processes from instrumentation. These are both part of the most recent Azure Linux App Services deployments and should not be instrumented.Verified correct behavior in an Azure Linux app service:
Resolves #2871