Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update excluded processes for Azure Linux App Service #2873

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Nov 4, 2024

BEGIN_COMMIT_OVERRIDE
fix: Don't instrument certain processes in Azure Linux App Service deployments. Resolves #2871.
END_COMMIT_OVERRIDE

Updates the Profiler to exclude kuduagent.dll and DiagServer processes from instrumentation. These are both part of the most recent Azure Linux App Services deployments and should not be instrumented.

Verified correct behavior in an Azure Linux app service:

[Trace] 2024-11-04 18:05:16 Checking to see if we should instrument this process. 
[Info ] 2024-11-04 18:05:16 Command line: /appservice/dotnet/dotnet /appservice/kuduagent/kuduagent.dll 
[Info ] 2024-11-04 18:05:16 This process will not be instrumented. Command line identified as invalid invocation for instrumentation 
[Info ] 2024-11-04 18:05:16 This process should not be instrumented, unloading profiler.

Resolves #2871

tippmar-nr and others added 2 commits November 4, 2024 11:31
chore: Update Profiler NuGet Package Reference to v10.33.1.3.

Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
@tippmar-nr tippmar-nr requested a review from a team as a code owner November 4, 2024 17:42
jaffinito
jaffinito previously approved these changes Nov 4, 2024
nrcventura
nrcventura previously approved these changes Nov 4, 2024
nr-ahemsath
nr-ahemsath previously approved these changes Nov 4, 2024
Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tippmar-nr tippmar-nr changed the title fix: Exclude kuduagent.dll from instrumentation fix: Update excluded processes for Azure Linux App Service Nov 4, 2024
chore: Update Profiler NuGet Package Reference to v10.33.1.6.

Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.41%. Comparing base (111d1a9) to head (1a241b0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2873   +/-   ##
=======================================
  Coverage   81.40%   81.41%           
=======================================
  Files         464      464           
  Lines       29524    29525    +1     
  Branches     3266     3266           
=======================================
+ Hits        24035    24037    +2     
+ Misses       4695     4692    -3     
- Partials      794      796    +2     
Flag Coverage Δ
Agent 82.34% <ø> (+0.03%) ⬆️
Profiler 73.07% <100.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nt/NewRelic/Profiler/Configuration/Configuration.h 74.84% <100.00%> (-2.42%) ⬇️

... and 2 files with indirect coverage changes

@tippmar-nr tippmar-nr enabled auto-merge (squash) November 4, 2024 20:04
@tippmar-nr tippmar-nr enabled auto-merge (squash) November 4, 2024 20:05
@tippmar-nr tippmar-nr merged commit 7ed945b into main Nov 4, 2024
94 checks passed
@tippmar-nr tippmar-nr deleted the fix/exclude-new-kudu branch November 4, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude kuduagent.dll from instrumentation
5 participants