Update SQL obfuscation tests to include cases for Active Record Query Logs #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prepended comments used in these tests are drawn from Active Record Query Logs/Marginalia-style comments. This is also known as sqlcommenter in other languages.
kaylareopelle
force-pushed
the
sql-testing
branch
from
8e16d94 to
c7e3d8b
Compare
SimpleCov Report
|
kaylareopelle
changed the title
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
approved these changes
Jan 30, 2024
tannalynn
approved these changes
Jan 31, 2024
|
I'm going to go ahead and merge this. PR to add this to our cross agent tests (internal) to avoid these new cases from being accidentally overwritten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SQL Obfuscation work in open-telemetry/opentelemetry-ruby-contrib#529 revealed we may have a gap in testing for queries prepended by comments in the style of Marginalia (pre-Rails 7) and Active Record Query Logs (Rails 7+).
This PR adds tests for those cases. If we choose to merge this PR, we'll need to follow-up with an update to the cross-agent tests, since these fixtures are synced with that repository. If we don't want to go that route, I'll move these tests so they're separate from the cross-agent tests.
This type of test may have cross-agent value because Google's sqlcommenter tool supports many different languages and databases and uses a similar syntax.