db explain plan refactor #2940
Merged
db explain plan refactor #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DRY up the similar explain plan logic that exists in both the AR and AR subscriber instrumentation - support AR v7.2+ by making use of `with_connection` when available
have the chain and prepend module files relatively include the main instrumentation file
test refactors to match explain plan DRY refactor
kaylareopelle
requested review from
hannahramadan and
tannalynn
as code owners
…ewrelic-ruby-agent into how_will_we_ever_explain_this
SimpleCov Report
|
kaylareopelle
approved these changes
Nov 15, 2024
hannahramadan
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_connectionwhen availableCloses #2922