NR-339475 Changing eventType from rokuVideo to videoAction #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpradhan-nr
reviewed
Nov 19, 2024
| @@ -265,7 +265,7 @@ function nrSendSystemEvent(actionName as String, attr = invalid) as Void | |||
| end function | |||
|
|
|||
| function nrSendVideoEvent(actionName as String, attr = invalid) as Void | |||
| ev = nrCreateEvent("RokuVideo", actionName) | |||
| ev = nrCreateEvent("VideoAction", actionName) | |||
There was a problem hiding this comment.
How are you differentiating VideoAdAction, VideoErrorAction & VideoCustomAction?
bmendiratta137
force-pushed
the
NR-339475-changing-EventType-from-RokuVideo-to-VideoAction
branch
from
f91609e
to
6b907fe
Compare
bmendiratta137
commented
Nov 24, 2024
| @@ -876,9 +887,9 @@ end function | |||
|
|
|||
| function nrEventApiUrl() as String | |||
| if m.nrRegion = "US" | |||
| return "https://insights-collector.newrelic.com/v1/accounts/" + m.nrAccountNumber + "/events" | |||
| return "https://staging-insights-collector.newrelic.com/v1/accounts/" + m.nrAccountNumber + "/events" | |||
bmendiratta137
commented
Nov 24, 2024
| else if m.nrRegion = "EU" | ||
| return "https://insights-collector.eu01.nr-data.net/v1/accounts/" + m.nrAccountNumber + "/events" | ||
| return "https://staging-insights-collector.eu01.nr-data.net/v1/accounts/" + m.nrAccountNumber + "/events" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA : https://new-relic.atlassian.net/browse/NR-339475
Changed event-type from RokuVideo to VideoAction