Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update replace-message - add support for optional commit ID filter #372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bairesearch
Copy link

update replace-message - add support for optional commit ID filter: end the line with '@CommitID#' and a commit ID to restrict the replacement expression to a particular commit.

For example;
foo==>bar@commitID#d760d24cf74a0ee68134d4b83a43d1e8ea3b6e1c

…nd the line with @CommitID# and a commit ID to restrict the replacement expression to a particular commit

Signed-off-by: Richard Baxter <richard.baxter@baxterai.com>
@bairesearch bairesearch force-pushed the branch-replaceMessageCommitFilter branch from c265921 to 939bbee Compare June 12, 2022 13:05
@tenkirin
Copy link

@newren
Any new progress about this one? I sought for this feature for a while and it turns out this feature is not merged yet.

@newren
Copy link
Owner

newren commented Nov 21, 2024

I'd rather do this similar to the --file-info-callback added in commit 6157207 (filter-repo: add a --file-info-callback, 2024-10-23), where the replace-text is available to the user in combination with both the file name and the file contents in a single callback, and the user can decide based on filename or file contents whether to apply the replace-text changes. Granted, that's in the context of modifying files, whereas this is considering commit messages, but the idea still translates -- make a callback where the user has access to both the commit message, the commit original_id, and the replace-message rules and can choose whether to apply them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants