Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-tests #218

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix-tests #218

merged 2 commits into from
Jan 13, 2025

Conversation

rayosborn
Copy link
Contributor

  • Removes tests that fail under Python 3.6 and 3.7. These use NumPy keyword arguments so the documentation will be updated to state that they are not supported in older Python versions.
  • Uses the packaging module to perform version comparisons.

@rayosborn
Use the packaging module for version checks
8c410f9
@rayosborn
Prevent tests of extra keyword arguments in Py3.6 and 3.7
fc065f2 
In particular, the `keepdims` keyword argument causes tests to fail for those Python versions.
@rayosborn rayosborn merged commit fec68d2 into nexpy:main Jan 13, 2025
15 checks passed
@rayosborn rayosborn deleted the fix-tests branch January 13, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rayosborn