-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for Markdown support of NcRichContenteditable #4355
Comments
CommentsCopied from nextcloud/spreed#1027
|
Also when selecting text and hitting BackSpace or Delete, the text should vanish and not the special key being killed/ignored because of the Formatting option popup |
So maybe only show this if selecting text with the mouse? Not sure if we can seperate between these... |
I think that the menu upon selecting the text would be useful (yes only on mouse and tap), but I would prefer to have a buttons bar with just the icons in line, just like in Nextcloud text's top-bar. I think it would be much less obtrusive. |
I'd personally prefer to have a user setting |
Wait I don't mean the whole bar, just a few action within the context menu |
@marcoambrosini you mean like a horizontal list only with icons instead of the vertical list that I suggested? |
Exactly, what do you think? |
I would honestly keep it for better UX.
I tried this but for a good UX we should have some kind of labels for the buttons imho and then the vertical list also with the choose formatting looks best imho. Here are the variants that I tried: |
Hmm I'm actually having a look at the competitors and there's to a widely adopted pattern of being able to toggle a formatting bar. What do you think about that @szaimen? It seems like a pretty good solution to me. Do I need formatting? -> I unfold it and it's there all the time. I think it's a very good solution UX-wise and it's also future proof, in case we want to introduce more functionality in the future. google chat Screen.Recording.2023-07-25.at.15.10.42.movslack Screen.Recording.2023-07-25.at.15.11.36.movteams Screen.Recording.2023-07-25.at.15.12.22.mov@ShGKme if you were previously referring to this I'm sorry, I misunderstood you. I thought you meant a setting in Talk settings. |
While usually I prefer to have a text near the icon and headers, I think in this case it is fine to keep only icons and remove any text out of tooltips. They are very wide-known icons that are used in all text editing apps and many messengers. With a text context menu - it is a context menu, and usually they do not have additional headers when not needed. In a horizontal menu bar, there is no space for text. So I'd prefer to remove the header and in the menu bar - also remove the text. (For a11y purpose, we can, of course, add hidden labels and headers.)
Actually, I meant Talk settings :D But having a switcher in the input is definitely better 👍
Yep, you can dismiss the menu by dismissing the selection (with any click or arrows). If you want to past this text in another place, then you have it in the clipboard and won't lose it after dismissing the selection.
A user can also still use the native context menu, like in Notion: So I'd keep the context formatting menu when the bar is not shown. |
I would avoid the context formatting if we have a bar option. I might think otherwise in a text document, but in Talk the purpose of a formatting bar would be avoiding that kind friction generated by a popover blocking parts of the message I'm writing. |
I would agree, that would also solve the keyboard/mixed usecase where otherwise you are always bothered by a formatting bar, while you are just trying to rewrite a section of your message or something alike. |
An alternative to a formatting bar would be something like this: nextcloud/text#4587. However the question would of course would be how good this would be discoverable for first-time users. |
And that requires picker support (e.g. not available in the talk desktop client atm). Something basic would be preferable I think. |
So a persistent bar in Talk and a on-selection-popover in vue? Yeah should be separate tickets 👍 |
I've been testing the formatting bar in Signal and I have to say it works pretty well in a chat application too. Since we're going to have that built into this component, we could test that with talk before adding a dedicated bar. @szaimen this is much less obtrusive than the labeled version and seems to be widely adopted. Signal example: Screen.Recording.2023-08-24.at.14.41.29.mov |
Mock-up for Markdown support of richtext
The popup should be shown after finishing the selection of some text (mouse button release) and should hide as soon as selecting one option. Also
[ESC]
should be able to close it.Originally posted by @szaimen in nextcloud/spreed#1027 (comment)
The text was updated successfully, but these errors were encountered: