automatically determine php/server versions for phpunit #248
Conversation
icewind1991
force-pushed
the
icewind1991-patch-2
branch
from
7414d6b to
5b06cb8
Compare
icewind1991
force-pushed
the
icewind1991-patch-2
branch
from
5b06cb8 to
5a94435
Compare
|
I just realized that with the existing actions mysql is the database that gets the full server/php version matrix, with sqlite,pgsql,oracle just getting the latest versions. Do we maybe want to switch this to only sqlite getting the full matrix? (as it is generally faster for ci runs) or should I adjust the PR to generate the mysql matrix instead? |
|
(see also #249 for more matrix generation) |
icewind1991
force-pushed
the
icewind1991-patch-2
branch
from
5a94435 to
1bb2769
Compare
icewind1991
changed the title
|
Changed it to keep the matrices the same but just automatically determine the versions. We can adjust what database jobs run what matrix separately |
We switched it specifically away from sqlite, as sqlite allows too much BS (you can store a string in an int column without DB error, etc) In talk the difference is 12 seconds, ~50 for mysql with ~38 for sqlite. |
workflow-templates/phpunit-mysql.yml
Outdated
| php-versions: ['8.0', '8.1', '8.2', '8.3'] | ||
| server-versions: ['master'] | ||
| php-versions: ${{fromJson(needs.matrix.outputs.php-versions)}} | ||
| server-versions: ${{ fromJson(needs.matrix.outputs.server-max) }} |
There was a problem hiding this comment.
Does something like php-versions also exist for server-"max" so you can loop over all supported server branches?
There was a problem hiding this comment.
Do you want the full NxM matrix?
There was a problem hiding this comment.
Not really, just thinking how this can be used by apps that support multiple versions and currently run something like: https://github.com/nextcloud/quota_warning/blob/main/.github/workflows/phpunit-mysql.yml#L41-L51 (but yeah that one currently seems to do NxM)
There was a problem hiding this comment.
switched to generating a matrix that covers all php and server versions with not-to-much™ redundancy.
The action itself now also generated the full NxM matrix (trimmed for supported versions) so we can easily switch to that if desired.
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
icewind1991-patch-2
branch
from
1bb2769 to
4e2a158
Compare
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Automatically run sqlite tests against all server versions listed as supported in
info.xmland the minimum supported php version for the server version.Example run: https://github.com/nextcloud/files_antivirus/actions/runs/6736095943
(also set
nextcloud/ocpto not be installed as it is specific to server/php versions and only needed for psalm anyway)