Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set up minimum supported instead of available php version #461

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Nov 19, 2024

Follow-up to #458

They are currently installing PHP 8.4 but PHP-CS-Fixer and Psalm are not yet compatible.

AFAIK, php-available is kind of a performance optimization. On the other hand, this blocks CI on apps until PHP 8.4 is ready for production.

Cs-fixer

Failing workflow: https://github.com/nextcloud/twofactor_totp/actions/runs/11918557008/job/33216257705?pr=1580
Fixed workflow: https://github.com/nextcloud/twofactor_totp/actions/runs/11919662884/job/33219864123?pr=1580

Psalm

Failing workflow: https://github.com/nextcloud/twofactor_totp/actions/runs/11919662892/job/33219863665?pr=1580
Fixed workflow: https://github.com/nextcloud/twofactor_totp/actions/runs/11919806670/job/33220330966?pr=1581

@st3iny st3iny added 3. to review Waiting for reviews bug Something isn't working labels Nov 19, 2024
@st3iny st3iny self-assigned this Nov 19, 2024
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/lint-php-cs/set-up-min-php-version branch from e63aeee to 32ca599 Compare November 19, 2024 18:52
@st3iny st3iny changed the title fix(lint-php-cs): set up minimum supported php version fix: set up minimum supported instead of available php version Nov 19, 2024
@st3iny st3iny requested a review from juliusknorr November 19, 2024 18:53
@st3iny st3iny merged commit ba6faac into master Nov 19, 2024
5 checks passed
@st3iny st3iny deleted the fix/lint-php-cs/set-up-min-php-version branch November 19, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants