Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interceptor #454

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Interceptor #454

wants to merge 2 commits into from

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 16, 2020

This adds possibility to add an interceptor to new OKHttpClient so that we can use pre-defined responses and do not have to use the server.

It is for now just a discussion.
I will open up a corresponding PR on files.

Ref: https://medium.com/ki-labs-engineering/an-easy-way-to-mock-an-api-response-using-retrofit-okhttp-and-interceptor-7968e1f0d050

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings22
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings41
Total127

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings41
Total127

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #454 into master will decrease coverage by 0.00%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   39.50%   39.50%   -0.01%     
==========================================
  Files         136      136              
  Lines        5895     5901       +6     
  Branches      771      773       +2     
==========================================
+ Hits         2329     2331       +2     
- Misses       3218     3222       +4     
  Partials      348      348              
Impacted Files Coverage Δ
...loud/android/lib/common/OwnCloudClientFactory.java 12.50% <0.00%> (-0.71%) ⬇️
.../main/java/com/nextcloud/common/NextcloudClient.kt 50.00% <62.50%> (-2.46%) ⬇️
...wncloud/android/lib/resources/files/FileUtils.java 85.71% <0.00%> (+14.28%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants