fix(ShareWrapperRequest): Save share attributes on creation #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Before this commit, attributes added to a share were ignored when the share type was team/circles (share type `7`). - Share attributes are not expected to contain any key or property named `enabled`. Partial resolution of: nextcloud/server#46920 This is a partial resolution because setting the `download` attribute may not fully enforce the correct download permissions. A follow-up PR in the server may be needed to update the `hideDownload` property of the share based on the value of `download` in the share attributes. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
approved these changes
Oct 31, 2024
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, attributes added to a share were ignored when the share type was team/circles (share type
7).Share attributes are not expected to contain any key or property named
enabled.Resolves : nextcloud/server#46920
This is a partial resolution because setting the
downloadattribute may not fully enforce the correct download permissions. A follow-up PR in the server may be needed to update thehideDownloadproperty of the share based on the value ofdownloadin the share attributes.