Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PageService): Handle errors with missing index files #1506

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix(PageService): Handle errors with missing index files #1506

merged 2 commits into from
Sep 25, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 25, 2024

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo-
fix(PageService): Create landing page if missing
c506df6 
Fixes: #943

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(PageService): Ignore folders if parent folder has no index page
51cfa46 
We cannot create missing index pages automatically in this case to
not break non-page folders like `.attachments` or user-managed
attachments folders.

Fixes: #1494

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added bug Something isn't working backend 3. to review labels Sep 25, 2024
@mejo- mejo- self-assigned this Sep 25, 2024
@mejo- mejo- merged commit c218cc0 into main Sep 25, 2024
51 of 53 checks passed
@mejo- mejo- deleted the fix/recreate_landing_page branch September 25, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels
3. to review backend bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not fetch pages (Readme.md) Cannot access collection anymore
2 participants
@mejo- @blizzz