Favorite pages #1545
Merged
Favorite pages #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancborchardt
approved these changes
Oct 22, 2024
nimishavijay
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Awesome! That looks super nice! 🚀
Only one small change: the chevron arrow on the "Favorites" item should be on the right, so that it's center aligned with the + button of the other pages :) Other than that it's perfect!
Approving to not block for another day 😅 Looking forward to seeing this in our handbook!
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/favourite_pages
branch
from
de29f8d to
8f21a37
Compare
Good point, changed now:
|
mejo-
force-pushed
the
feat/favourite_pages
branch
2 times, most recently
from
9e2b590 to
bc286fd
Compare
Fixes: #300 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/favourite_pages
branch
from
bc286fd to
6c6e8da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Allow to mark pages as favorites. Favorites will get additionally listed in a collapsible "Favorites" section at the top of the page list.
Resolves: #300
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)