Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share): Add owner sharing permission for folder of public share #1548

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(share): Add owner sharing permission for folder of public share #1548

merged 1 commit into from
Oct 28, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Oct 23, 2024

Fixes: #1530

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@mejo- mejo- added bug Something isn't working bug: regression 3. to review labels Oct 23, 2024
@mejo- mejo- requested review from susnux and juliusknorr October 23, 2024 14:54
@mejo- mejo- self-assigned this Oct 23, 2024
@mejo- mejo- requested a review from max-nextcloud as a code owner October 23, 2024 14:54
@mejo-
fix(share): Add owner sharing permission for folder of public share
681a8a7 
Fixes: #1530

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/share_permissions branch from 79021e9 to 681a8a7 Compare October 23, 2024 14:55
@mejo-
Copy link
Member Author

mejo- commented Oct 23, 2024

Might also fix #1027

@mejo-
Copy link
Member Author

mejo- commented Oct 23, 2024

Cypress failure unrelated.

@juliusknorr juliusknorr merged commit 2575510 into main Oct 28, 2024
51 of 53 checks passed
@juliusknorr juliusknorr deleted the fix/share_permissions branch October 28, 2024 09:56
@mejo- mejo- mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@susnux susnux Awaiting requested review from susnux

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels
3. to review bug: regression bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blank pages on shared collective
2 participants
@mejo- @juliusknorr