test(cypress): Make page list trash test retriable #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this will actually make the test more robust. If the test already fails in the new |
mejo-
approved these changes
Sep 14, 2023
mejo-
force-pushed
the
test/retryable-page-list-trash-test
branch
from
cfcf8d2 to
34d5de7
Compare
mejo-
requested changes
Sep 21, 2023
Only insert the attachment once. When opening the page for the first time it is in edit mode and the attachment can be inserted. On test retries the attachment was already there and the page opened in view mode. This led to test failures when attempting to switch to view mode. Signed-off-by: Max <max@nextcloud.com>
mejo-
force-pushed
the
test/retryable-page-list-trash-test
branch
from
34d5de7 to
68ea4f3
Compare
|
@max-nextcloud do you want to follow-up on this one or shall we close it for now? |
|
I can just open a new one based on the current cypress tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only insert the attachment once.
When opening the page for the first time
it is in edit mode and the attachment can be inserted.
On test retries the attachment was already there
and the page opened in view mode.
This led to test failures when attempting to switch to view mode.