Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible recent pages #894

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Collapsible recent pages #894

merged 6 commits into from
Sep 25, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 21, 2023

📝 Summary

  • Members widget moved to the top and remove its caption
  • Decreased top margin for captions

Fixes: #835

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@mejo- mejo- added bug Something isn't working 3. to review labels Sep 21, 2023
@mejo- mejo- requested a review from max-nextcloud September 21, 2023 12:54
@mejo- mejo- force-pushed the fix/landingpage_widgets branch from 7341568 to e146317 Compare September 21, 2023 13:00
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice and cleanly separated into the differen commits. I just have one small comment.

@mejo- mejo- force-pushed the fix/landingpage_widgets branch from e146317 to 06ce14a Compare September 25, 2023 13:43
* Members widget moved to the top and remove its caption
* Decreased top margin for captions

Fixes: #835

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Also use `v-show` instead of `v-if` for recent pages to solve issues
with registering events on its element.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/landingpage_widgets branch from 06ce14a to e527671 Compare September 25, 2023 13:46
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/landingpage_widgets branch from e527671 to ea83450 Compare September 25, 2023 15:28
@mejo- mejo- merged commit af9aba0 into main Sep 25, 2023
35 of 38 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/landingpage_widgets branch September 25, 2023 16:35
@punkyard
Copy link

please, remove Recent pages, Landing page and contributors from the edition frame of Collectives.

If people need this, could it be displayed for them in the left frame of the screen, with the menu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improved landing page clutters the view of the landing page
3 participants