Fix visual glitches #896
Merged
Fix visual glitches #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the background is primary for me in the sidebar but the font color is black (testing with Nextcloud 27): Looking at how other apps (talk, contacts) handle this the selected element in the navigation has a slighly brighter background and black font ( in bright mode).
|
max-nextcloud
requested changes
Sep 21, 2023
mejo-
force-pushed
the
fix/visual_glitches
branch
from
fb8f15a to
3c54b73
Compare
Agreed. Actually the issue reported here got already fixed in |
Signed-off-by: Jonas <jonas@freesources.org>
* Prevent cut off edges in emoji button * Prevent cut off lower letter parts in title with some fonts Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/visual_glitches
branch
from
3c54b73 to
38d22c7
Compare
max-nextcloud
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)