Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a read-only contactdetails component #4194

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Oct 23, 2024

this will be the readonly component to be used on contacts and mail

ref: nextcloud/mail#9622

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD requested a review from st3iny October 23, 2024 12:48
@GretaD
Copy link
Contributor Author

GretaD commented Oct 23, 2024

@st3iny its still a draft, but if you already have comments, please let me know :)

@GretaD GretaD changed the title feat: create a readonly contactdetails feat: create a read-only contactdetails component Oct 23, 2024
@GretaD GretaD self-assigned this Oct 23, 2024
@GretaD GretaD added the 2. developing Work in progress label Oct 23, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.75%. Comparing base (5a6e006) to head (a096183).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
lib/Listener/LoadContactsOcaApi.php 0.00% 6 Missing ⚠️
lib/AppInfo/Application.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4194      +/-   ##
============================================
- Coverage     66.33%   65.75%   -0.58%     
- Complexity      263      266       +3     
============================================
  Files            25       26       +1     
  Lines           799      806       +7     
============================================
  Hits            530      530              
- Misses          269      276       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants