Skip to content

Commit

Permalink
Prevent empty password being passed into share creation
Browse files Browse the repository at this point in the history
We already generate a new password when the share password dialog is
created, so there is really no need to clear the field when it closes.
This prevents the field being cleared before the password is sent into
the C++ code, leading to no password actually being sent to the server

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
  • Loading branch information
claucambra committed Sep 28, 2023
1 parent 56c25a9 commit f3ea30c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/gui/filedetails/ShareView.qml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ ColumnLayout {

visible: false
onAboutToShow: dialogPasswordField.text = shareModel.generatePassword()
onClosed: dialogPasswordField.text = ""

onAccepted: {
if(sharee) {
Expand Down

0 comments on commit f3ea30c

Please sign in to comment.