fix computation of timeout for jobs to have proper bounds (min < max)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
nextcloud · Sep 17, 2023 · fc8588f · fc8588f
1 parent 5eb4f4b
commit fc8588f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/libsync/propagateupload.cpp b/src/libsync/propagateupload.cpp
@@ -709,13 +709,14 @@ void PropagateUploadFileCommon::commonErrorHandling(AbstractNetworkJob *job)
 void PropagateUploadFileCommon::adjustLastJobTimeout(AbstractNetworkJob *job, qint64 fileSize)
 {
     constexpr double threeMinutes = 3.0 * 60 * 1000;
+    constexpr qint64 thirtyMinutes = 30 * 60 * 1000;
 
     job->setTimeout(qBound(
-        job->timeoutMsec(),
         // Calculate 3 minutes for each gigabyte of data
-        qRound64(threeMinutes * fileSize / 1e9),
+        qMin(thirtyMinutes - 1, qRound64(threeMinutes * fileSize / 1e9)),
+        job->timeoutMsec(),
         // Maximum of 30 minutes
-        static_cast<qint64>(30 * 60 * 1000)));
+        thirtyMinutes));
 }
 
 void PropagateUploadFileCommon::slotJobDestroyed(QObject *job)