Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable reversed locale layout (RTL) in QML #4240

Merged
merged 1 commit into from
Dec 3, 2024
Merged

enable reversed locale layout (RTL) in QML #4240

merged 1 commit into from
Dec 3, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Feb 2, 2022

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien
Copy link
Collaborator Author

mgallien commented Feb 2, 2022

reversed main dialog
image

@mgallien mgallien force-pushed the bugfix/enableLayoutMirroringInQml branch from f53b347 to f61a05d Compare February 2, 2022 13:08
@mgallien
Copy link
Collaborator Author

mgallien commented Feb 2, 2022

main dialog
image

@claucambra
Copy link
Collaborator

The username label in the user button that invokes the dropdown also needs its alignment reversed

@jancborchardt
Copy link
Member

reversed main dialog
image

All the text needs to be right-aligned for RTL. Otherwise looks good! :)

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rodrigoscoelho
Copy link

AppImage file: Nextcloud-PR-4240-315cb6aa32283b0b6384f688b942baf537da4427-x86_64.AppImage To test this change/fix you can simply download above AppImage file and test it. Please make sure to quit your existing Nextcloud app and backup your data.

May you explain how to test this image?

Is it a .exe? Just rename?

thanks

@claucambra
Copy link
Collaborator

AppImage file: Nextcloud-PR-4240-315cb6aa32283b0b6384f688b942baf537da4427-x86_64.AppImage To test this change/fix you can simply download above AppImage file and test it. Please make sure to quit your existing Nextcloud app and backup your data.

May you explain how to test this image?

Is it a .exe? Just rename?

thanks

AppImage executables are Linux-only

@claucambra
Copy link
Collaborator

This needs a rebase :)

@mgallien mgallien force-pushed the bugfix/enableLayoutMirroringInQml branch from 315cb6a to d7cc9f8 Compare May 4, 2022 08:26
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra
Copy link
Collaborator

These labels need their alignment changed in the Right-To-Left layout to match how they are laid out in the Left-To-Right layout:

Screenshot 2022-05-04 at 11 46 34

Screenshot 2022-05-04 at 11 53 46

Once rebased the layout of the activity item contents are also not right-aligned when in Right-To-Left:

Screenshot 2022-05-04 at 11 55 52

@claucambra
Copy link
Collaborator

The unified search also doesn't seem to respond to RTL layout:

Screenshot 2022-05-04 at 12 04 39

@mgallien mgallien force-pushed the bugfix/enableLayoutMirroringInQml branch from d7cc9f8 to c7e64b6 Compare October 1, 2022 12:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 1, 2022 •
edited
Loading

Codecov Report

Merging #4240 (ea409d3) into master (a91c96b) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4240      +/-   ##
==========================================
+ Coverage   60.32%   60.33%   +0.01%     
==========================================
  Files         145      145              
  Lines       18800    18800              
==========================================
+ Hits        11341    11343       +2     
+ Misses       7459     7457       -2

see 2 files with indirect coverage changes

@mgallien mgallien force-pushed the bugfix/enableLayoutMirroringInQml branch from c7e64b6 to ea409d3 Compare September 25, 2023 14:23
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien force-pushed the bugfix/enableLayoutMirroringInQml branch from ea409d3 to 4c96657 Compare November 29, 2024 10:36
@mgallien
Copy link
Collaborator Author

image
after rebase

@Rello Rello added this to the 3.16.0 milestone Dec 3, 2024
@mgallien
enable reversed locale layout in QML
1eacbb9 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/enableLayoutMirroringInQml branch from 4c96657 to 1eacbb9 Compare December 3, 2024 10:49
@mgallien mgallien enabled auto-merge December 3, 2024 10:49
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4240-1eacbb97bf0c923c9987e7ba6fe667bac303af1f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)
12 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 724035f into master Dec 3, 2024
13 of 16 checks passed
@mgallien mgallien deleted the bugfix/enableLayoutMirroringInQml branch December 3, 2024 11:42
@Rello Rello changed the title enable reversed locale layout in QML enable reversed locale layout (RTL) in QML Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra left review comments

@camilasan camilasan camilasan approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@allexzander allexzander Awaiting requested review from allexzander

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
1. to develop
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mgallien @claucambra @jancborchardt @rodrigoscoelho @nextcloud-desktop-bot @camilasan @Rello