Improve talk reply #4385
Merged
Improve talk reply #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
camilasan
commented
Mar 24, 2022
camilasan
commented
mgallien
reviewed
Mar 25, 2022
camilasan
force-pushed
the
bugfix/talk-reply
branch
from
66b4faf to
7314c82
Compare
added 6 commits
March 28, 2022 16:04
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
camilasan
force-pushed
the
bugfix/talk-reply
branch
from
7314c82 to
7cc2486
Compare
allexzander
reviewed
Mar 28, 2022
| @@ -608,6 +614,12 @@ void ActivityListModel::slotTriggerAction(const int activityIndex, const int act | |||
|
|
|||
| const auto action = activity._links[actionIndex]; | |||
|
|
|||
| // TODO this will change with https://github.com/nextcloud/desktop/issues/4159 | |||
| if (action._verb == "WEB" && action._label == tr("View chat")) { | |||
There was a problem hiding this comment.
@camilasan I hope it does get changed. Comparing translated strings doesn't look reliable.
There was a problem hiding this comment.
allexzander
approved these changes
Mar 28, 2022
|
SonarCloud Quality Gate failed. |
|
AppImage file: Nextcloud-PR-4385-7cc2486d79711ebd47ff1c2f35ed659619462abe-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.