Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Change to a capital letter #4953

Merged
merged 1 commit into from
Dec 4, 2024
Merged

l10n: Change to a capital letter #4953

merged 1 commit into from
Dec 4, 2024

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Sep 18, 2022

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #4953 (dba4e18) into master (9f952e3) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head dba4e18 differs from pull request most recent head 2fe3801. Consider uploading reports for the commit 2fe3801 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4953      +/-   ##
==========================================
+ Coverage   56.98%   57.12%   +0.13%     
==========================================
  Files         138      138              
  Lines       17232    17232              
==========================================
+ Hits         9819     9843      +24     
+ Misses       7413     7389      -24     
Impacted Files Coverage Δ
src/libsync/owncloudpropagator.cpp 85.88% <100.00%> (ø)
src/libsync/propagatedownload.cpp 64.61% <100.00%> (ø)
src/libsync/propagateremotemove.cpp 82.28% <100.00%> (ø)
src/libsync/propagatorjobs.cpp 73.23% <100.00%> (ø)
src/libsync/syncfileitem.h 37.50% <0.00%> (ø)
src/libsync/bulkpropagatorjob.cpp 73.10% <0.00%> (ø)
src/libsync/progressdispatcher.cpp 51.17% <0.00%> (ø)
src/libsync/syncengine.cpp 85.56% <0.00%> (+0.53%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.42% <0.00%> (+1.82%) ⬆️
... and 2 more

@camilasan camilasan self-requested a review September 20, 2022 12:27
Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, just remove the merge commit.

@Valdnet
Copy link
Contributor Author

Valdnet commented Sep 20, 2022

@camilasan Delete a commit and re-add it to the merge?

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@camilasan
Copy link
Member

@camilasan Delete a commit and re-add it to the merge?

You seem to have done it right, but now there are 5 commits. Could you squash them?
Sorry for the late reply on this.

@Valdnet
Copy link
Contributor Author

Valdnet commented Dec 7, 2022

Could you squash them?

@camilasan I make changes from the GitHab level and I have no way to squash directly. Can you do this with Git?

@Rello Rello added this to the 3.15.1 milestone Dec 4, 2024
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4953-548326f48921bbe5330f33ef9d4cdf557b3a1030-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
41 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@camilasan camilasan merged commit 11254e8 into master Dec 4, 2024
14 of 17 checks passed
@camilasan camilasan deleted the Valdnet-patch-2 branch December 4, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants