Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmc/runwizard_introduction #5870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnkurBavisa
Copy link

@AnkurBavisa AnkurBavisa commented Jul 6, 2023

Update run wizard introduction screen UI.
Modified "Copy Link" & "Reopen Browser" with QPushButton to apply stylesheet.
Attached screen shots of UI change & final output[before & After], also attached screenshots of MagentCloud output screen for stylesheet reference.

--NC_Run_Wizard_Intro_After--
NC_Run_Wizard_Intro_After

--NC_Run_Wizard_Intro_Before--
NC_Run_Wizard_Intro_Before

--NC_UI_Design_After--
NC_UI_Design_After

--NC_UI_Design_Before--
NC_UI_Design_Before

--MagentCloud reference screen--
MagentaCloud_Reference

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a nice change :) CCing @jancborchardt

@mgallien
Copy link
Collaborator

mgallien commented Jul 12, 2023

@AnkurBavisa can you rebase the branch ?
Looks good from a code point of view
I will approve the workflow to get better test coverage (SonarCloud will still fail due to the private token and me not having a solution)

@AnkurBavisa AnkurBavisa force-pushed the nmc/runwizard_introduction branch 2 times, most recently from 2c8650e to 40f0e91 Compare July 12, 2023 14:16
@AnkurBavisa
Copy link
Author

@AnkurBavisa can you rebase the branch ? Looks good from a code point of view I will approve the workflow to get better test coverage (SonarCloud will still fail due to the private token and me not having a solution)

Yes, done

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice! great improvement :)
I would suggest that the wording be changed form "Reopen browser" to "Open browser" since it has been made the primary button, and it would be likely be clicked only if the browser hasn't been opened yet. Other than that small change, it looks great! :)

src/gui/wizard/flow2authwidget.cpp Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the nmc/runwizard_introduction branch 2 times, most recently from e7ea512 to 25ff592 Compare July 24, 2023 13:00
@camilasan camilasan enabled auto-merge July 24, 2023 13:00
@camilasan camilasan force-pushed the nmc/runwizard_introduction branch from 25ff592 to e0ff427 Compare August 17, 2023 12:40
Signed-off-by: Ankur Bavisa <Ankur.Bavisa@t-systems.com>
@camilasan camilasan force-pushed the nmc/runwizard_introduction branch from e0ff427 to a1efbef Compare September 18, 2023 13:52
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #5870 (a1efbef) into master (24a9dc5) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5870   +/-   ##
=======================================
  Coverage   60.24%   60.25%           
=======================================
  Files         145      145           
  Lines       18868    18868           
=======================================
+ Hits        11367    11368    +1     
+ Misses       7501     7500    -1     

see 1 file with indirect coverage changes

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5870-a1efbef19468a736cebba479502b312c739557a5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@memurats memurats deleted the nmc/runwizard_introduction branch September 30, 2024 13:03
@Rello Rello added this to the 3.16.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants