Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder wizard warning color for local path in dark mode #5968

Merged
merged 4 commits into from
Sep 16, 2023

Conversation

claucambra
Copy link
Collaborator

We had originally fixed this for the remote path, but not for the local path. Without this fix the warning is unreadable

Fixes #5852

@claucambra claucambra self-assigned this Aug 13, 2023
@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #5968 (e6676ac) into master (1313427) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5968   +/-   ##
=======================================
  Coverage   60.24%   60.24%           
=======================================
  Files         145      145           
  Lines       18868    18868           
=======================================
  Hits        11367    11367           
  Misses       7501     7501           

src/gui/folderwizard.cpp Outdated Show resolved Hide resolved
@claucambra claucambra requested a review from allexzander August 23, 2023 01:12
@claucambra
Copy link
Collaborator Author

/backport to stable-3.10

@allexzander
Copy link
Contributor

@claucambra Kindly squash your commits

@claucambra claucambra force-pushed the bugfix/dark-mode-folder-wizard-warning-color branch 3 times, most recently from d2af11d to bb4718f Compare September 14, 2023 02:48
@mgallien mgallien force-pushed the bugfix/dark-mode-folder-wizard-warning-color branch from bb4718f to 4762fcb Compare September 16, 2023 09:44
…ct colour

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…amespace function

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/dark-mode-folder-wizard-warning-color branch from 4762fcb to e6676ac Compare September 16, 2023 17:29
@mgallien mgallien enabled auto-merge September 16, 2023 17:30
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5968-e6676ac0f05556f614fe9baeefaadc083b04e4b9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mgallien mgallien merged commit 6ebc94f into master Sep 16, 2023
12 of 13 checks passed
@mgallien mgallien deleted the bugfix/dark-mode-folder-wizard-warning-color branch September 16, 2023 17:58
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sync warning is unreadable on Mac under dark mode
4 participants