Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Nextcloud after installation on macOS #5991

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Open Nextcloud after installation on macOS #5991

merged 1 commit into from
Sep 19, 2023

Conversation

claucambra
Copy link
Collaborator

Closes #2899

@claucambra claucambra self-assigned this Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #5991 (2bfafcc) into master (6cf04d6) will decrease coverage by 0.24%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 2bfafcc differs from pull request most recent head 4660c6e. Consider uploading reports for the commit 4660c6e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5991      +/-   ##
==========================================
- Coverage   60.34%   60.10%   -0.24%     
==========================================
  Files         145      145              
  Lines       18793    18806      +13     
==========================================
- Hits        11340    11304      -36     
- Misses       7453     7502      +49

see 29 files with indirect coverage changes

@claucambra
Copy link
Collaborator Author

/backport to stable-3.10

@mgallien mgallien enabled auto-merge September 18, 2023 14:07
@mgallien mgallien force-pushed the bugfix/macos-open-after-install branch from 2bfafcc to c9ae01b Compare September 18, 2023 14:07
@claucambra
Open Nextcloud after installation on macOS
4660c6e 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/macos-open-after-install branch from c9ae01b to 4660c6e Compare September 19, 2023 07:46
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5991-4660c6ebaed4ab9d52d68ab994c7e021ecfb59c8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien merged commit ee34584 into master Sep 19, 2023
11 checks passed
@mgallien mgallien deleted the bugfix/macos-open-after-install branch September 19, 2023 09:40
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 19, 2023
Merged
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

Nothing happens after app installation on macOS
3 participants
@claucambra @nextcloud-desktop-bot @mgallien