[stable-3.10] fixed detection of server version in cmd client similar to gui client (2nd try, signed off) #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
first check status.php for version and then capabilities, only use version string if not empty this also fixes 'File names containing the character ":" are not supported on this file system.' errors in nextcloudcmd (on Linux): The invalidFilenameRegex was set to a static default in case the server version was not set correctly. As newer versions of nextcloud do not return the version in capabilities but status.php, the server version was empty. Signed-off-by: Patrick Cernko <errror@errror.org>
|
AppImage file: nextcloud-PR-6033-80be0bec3d8efd79ee06df0fd15fc21822e05677-x86_64.AppImage |
|
SonarCloud Quality Gate failed.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## stable-3.10 #6033 +/- ##
===============================================
+ Coverage 60.13% 60.14% +0.01%
===============================================
Files 145 145
Lines 18868 18868
===============================================
+ Hits 11346 11349 +3
+ Misses 7522 7519 -3 |
claucambra
approved these changes
Sep 7, 2023
claucambra
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6023