Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visual bug with folder size confirmation combo box in general settings #6035

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix visual bug with folder size confirmation combo box in general settings #6035

merged 1 commit into from
Sep 11, 2023

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Sep 7, 2023 •
edited
Loading

After fix

Screenshot 2023-09-07 at 15 05 37

Before fix

Screenshot 2023-09-08 at 10 30 10

@claucambra claucambra changed the title Fix visual bug with folder size confirmation combo box in general set… Fix visual bug with folder size confirmation combo box in general settings Sep 7, 2023
@claucambra claucambra self-assigned this Sep 7, 2023
@claucambra
Copy link
Collaborator Author

/backport to stable-3.10

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #6035 (a2015c7) into master (a148e4e) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a2015c7 differs from pull request most recent head 3abbeef. Consider uploading reports for the commit 3abbeef to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6035   +/-   ##
=======================================
  Coverage   60.14%   60.14%           
=======================================
  Files         145      145           
  Lines       18872    18868    -4     
=======================================
- Hits        11350    11349    -1     
+ Misses       7522     7519    -3

see 3 files with indirect coverage changes

mgallien
mgallien requested changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also post a screenshot of the state before your patch ?

@claucambra
Copy link
Collaborator Author

claucambra commented Sep 8, 2023 •
edited
Loading

can you also post a screenshot of the state before your patch ?

Yes, of course, here's what it looks like before the fix (notice the text clipping the spin box)

Screenshot 2023-09-08 at 10 30 10

@claucambra claucambra requested a review from mgallien September 8, 2023 02:40
@claucambra @mgallien
Fix visual bug with folder size confirmation combo box in general set…
3abbeef 
…tings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/visual-bug-folder-size-conf branch from a2015c7 to 3abbeef Compare September 11, 2023 16:36
@mgallien mgallien enabled auto-merge September 11, 2023 16:36
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6035-3abbeefe62f78cea7ef684e01d8e9ac91a47601a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien merged commit a406924 into master Sep 11, 2023
10 checks passed
@mgallien mgallien deleted the bugfix/visual-bug-folder-size-conf branch September 11, 2023 17:07
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 11, 2023
Merged
@mgallien mgallien added this to the 3.11.0 milestone Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@claucambra @nextcloud-desktop-bot @mgallien