Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.9] once we call done on a sync file item, return is needed #6055

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[stable-3.9] once we call done on a sync file item, return is needed #6055

merged 1 commit into from
Sep 14, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #6053

@mgallien @backportbot-nextcloud
once we call done on a sync file item, return is needed
6340ced 
will avoid calling done method multiple times on a signle file item
causing a crash via ENFORCE function

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #6055 (6340ced) into stable-3.9 (9bce16e) will decrease coverage by 0.03%.
Report is 2 commits behind head on stable-3.9.
The diff coverage is 0.00%.

Additional details and impacted files 
@@              Coverage Diff               @@
##           stable-3.9    #6055      +/-   ##
==============================================
- Coverage       60.52%   60.50%   -0.03%     
==============================================
  Files             145      145              
  Lines           18680    18680              
==============================================
- Hits            11307    11303       -4     
- Misses           7373     7377       +4
Files Changed Coverage Δ
src/libsync/propagatedownload.cpp 66.85% <0.00%> (ø)

... and 3 files with indirect coverage changes

@mgallien mgallien enabled auto-merge September 14, 2023 13:27
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6055-6340cedfab9309567269fcb0a623365e6af5140b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 3778e43 into stable-3.9 Sep 14, 2023
11 of 12 checks passed
@mgallien mgallien deleted the backport/6053/stable-3.9 branch September 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nextcloud-desktop-bot @mgallien